Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET-282: Remove Proxy fields #2388

Merged
merged 4 commits into from
Jun 12, 2023
Merged

NET-282: Remove Proxy fields #2388

merged 4 commits into from
Jun 12, 2023

Conversation

abhishek9686
Copy link
Member

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide testing steps

refer gravitl/netclient#453

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@abhishek9686 abhishek9686 mentioned this pull request Jun 9, 2023
Merged
10 tasks
theguy951357
theguy951357 approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr passes

@abhishek9686 abhishek9686 merged commit 90bbd41 into refactor_peer_updates Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkasun mattkasun mattkasun approved these changes

@theguy951357 theguy951357 theguy951357 approved these changes

@TobiaszCudnik TobiaszCudnik TobiaszCudnik approved these changes

@Aceix Aceix Awaiting requested review from Aceix

@gabrielseibel1 gabrielseibel1 Awaiting requested review from gabrielseibel1

@afeiszli afeiszli Awaiting requested review from afeiszli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhishek9686 @TobiaszCudnik @theguy951357 @mattkasun